Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FillStyleExtension leverages new default props behavior #7569

Merged
merged 3 commits into from Jan 9, 2023
Merged

FillStyleExtension leverages new default props behavior #7569

merged 3 commits into from Jan 9, 2023

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Jan 6, 2023 •
edited

Follow up of #7496

Change List

  • Remove ad-hoc prop handling in FillStyleExtension, use core async resolution system
  • image prop type accepts a new option to override default texture parameters
  • Tests
  • Docs

Base automatically changed from x/fill-ext to master January 7, 2023 19:07
@felixpalmer felixpalmer mentioned this pull request Jan 9, 2023
Open
@coveralls
Copy link

Coverage Status

Coverage: 90.088% (+0.02%) from 90.07% when pulling 9b9832f on x/fill-ext-2 into b09ea63 on master.

@Pessimistress Pessimistress merged commit b2a25b6 into master Jan 9, 2023
@Pessimistress Pessimistress deleted the x/fill-ext-2 branch January 9, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @felixpalmer