Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect prop type on internalTextures #7570

Closed
6 tasks
jeffpeck10x opened this issue Jan 8, 2023 · 1 comment
Closed
6 tasks

[Bug] Incorrect prop type on internalTextures #7570

jeffpeck10x opened this issue Jan 8, 2023 · 1 comment
Labels

Comments

@jeffpeck10x
Copy link
Contributor

Description

https://github.com/visgl/deck.gl/blob/master/modules/core/src/utils/texture.ts#L14

I think this:

const internalTextures: Record<string, Texture2D> = {};

should actually be this:

const internalTextures: Record<string, boolean> = {};

https://github.com/visgl/deck.gl/blob/master/modules/core/src/utils/texture.ts#L14

Flavors

  • React
  • Python/Jupyter notebook
  • MapboxLayer
  • GoogleMapsOverlay
  • CartoLayer
  • DeckLayer/DeckRenderer for ArcGIS

Expected Behavior

n/a

Steps to Reproduce

n/a

Environment

  • Framework version:
  • Browser:
  • OS:

Logs

No response

@jeffpeck10x jeffpeck10x added the bug label Jan 8, 2023
@Pessimistress
Copy link
Collaborator

Closed by #7652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants