New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 - scatterplot not rendering anymore #97
Comments
Missed a breaking API change - my bad. Core scatterplot works now - FP64 (and other layers I listed) still the same. |
Fixed by #102 |
Err, I take that back. Even on beta 21 the fp64 scatterplot is still not rendering. |
@contra what platform are you running on? macOS with Intel GPU? are you testing using the example layers from "npm start" |
Example page works (latest dev branch as of now), npm published release (3.0.0-beta21) does not work in my codebase. Maybe a fix landed that didn't get published? Not sure. My code runs fine with the core layer, just not the FP64 layer. Updated list of layers that aren't working in the example: |
Seeing similar issues. Upgraded to 3.0.0-beta21 in attempt to fix the offset issue our non-retina macbook users were seeing (#91). While beta21 works on my machine, my macbook air now sees this error: Here are the specs: |
Not getting any errors so it might be two different issues. @jshanson7 Your error is from the fp64 or the core layer? |
Yeah... we are aware of the issue and put in a hotfix for Intel GPUs... can I'll land a more proper fix hopefully today On Wed, Oct 19, 2016 at 3:31 PM, Jeff Hanson notifications@github.com
Best Wishes Shaojing Li |
@contra actually yes that might have been from the fp64 layer -- I did see errors from the non-fp64 layer but it seems I took a screenshot of the wrong console. Will investigate further when I get a chance. |
@contra @jshanson7 the issue is from the 32-bit layers and it only shows on computers with Intel GPUs. |
@shaojingli The 32 bit layer works fine for me, the 64 bit is the one that isn't working for me. |
@sjhanson7 @contra - Just to make sure you have the context: We are making a push to get ready for the release of deck.gl v3, and this is the right time for us to make breaking changes, since we will want to stay stable once we release officially. So the beta releases will likely remain a little unstable for another week or so. That said, these reports really help us fix what's broken, so they are appreciated. |
beta22 should fix this |
@ibgreen Just tested on beta22 - doesn't seem to be fixed. The new fp64 choropleths work great though! |
@contra I tested scatterplot64 on beta22 and it works on Intel/AMD GPUs on OS X and on Intel/Nvidia GPUs on Windows. Unfortunately, I don't have the 2013 MacBook Pro with Nvidia GPU... it's weird that choropleth64 works but scatterplot64 doesn't.... any console outputs for scatterplot64? |
@shaojingli No output on the console. |
@contra can you pull the latest dev, run 'npm run test-shader' and report the results here |
@shaojingli Console:
Page:
|
hi @contra is scatterplot64 still broken on your 2013 macbook pro with nvidia gpu? |
@shaojingli I'll close it for now - will test later today and if it's still a problem I'll reopen. |
Still an issue, FP64 busted - just tested on latest. |
Still present on 3.1.1 |
@contra thank you for your efforts on testing the layers. By "FP64 busted", do you mean they are not rendering? or they are wobbling? or other issues? I managed to obtain a Macbook Pro with Nvidia GT650M GPU. I can see all 64-bit layers rendering without problems. There some small rendering defects happening though. E. g. if you look at 64-bit scatterplot layer close up, you can see the shape of the circle changes slightly when zooming. It doesn't show up when panning or rotating the layer. Is this what you are referring to? |
@shaojingli "busted" = failing to render I'll try again on latest and report the results. |
@shaojingli Just tested on latest everything, 64 bit scatterplot points still not showing up (same as before). |
@contra, thanks a lot for getting back to me so quickly. this is my environment: MacBook Pro (Mid 2012), NVIDIA GeForce GT650M 1024MB, OS X 10.11.6 (15G31) |
@shaojingli Tests were w/ cache clean My laptop has the GT650M and the Intel HD Graphics 4000 and doesn't work. Maybe the issue is w/ intel gpus? |
I found the root cause of the issue. It's that data source doesn't provide correct z component for each point. Anyway, this will be fixed once #283 landed. |
@shaojingli Is there going to be a patch release after #283 ? |
@shaojingli Nice, thanks for the hotfix - are you planning on publishing that as 3.1.2? |
Works fine on latest 2.x, updating to 3.x causes scatterplots to quit rendering.
Additional info:
3.0.0-beta17
Tested the latest dev branch demo and the core scatter layer works, but the fp64 does not.
Not sure if you're worried about it since it is a dev branch, but these layers don't work on the 3.x dev branch demo:
The text was updated successfully, but these errors were encountered: