Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Website] Render nested categories in side bar #1482

Merged
merged 2 commits into from Feb 28, 2018
Merged

[Website] Render nested categories in side bar #1482

merged 2 commits into from Feb 28, 2018

Conversation

Pessimistress
Copy link
Collaborator

For #1470

Change List

  • Support sub headers in table of contents
  • Support badges
  • Render wider side bar in large window

screen shot 2018-02-27 at 4 38 23 pm

balthazar
balthazar approved these changes Feb 28, 2018
View reviewed changes
website/src/components/table-of-contents.js Outdated
const INDENT_BASE = 16;
const INDENT_INC = 12;

function getContentHeight(page) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat:

const getContentHeight = page =>
  page.children
    ? page.children.reduce((acc, child) => acc + getContentHeight(child), ITEM_HEIGHT)
    : ITEM_HEIGHT

@Pessimistress Pessimistress merged commit 86ac03e into master Feb 28, 2018
@Pessimistress Pessimistress deleted the table-of-contents branch February 28, 2018 01:17
Pessimistress added a commit that referenced this pull request Feb 28, 2018
@Pessimistress
[Website] Render nested categories in side bar (#1482)
85d6b08
@jianhuang01 jianhuang01 added doc and removed code labels Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balthazar balthazar balthazar approved these changes

@jianhuang01 jianhuang01 jianhuang01 approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @balthazar @jianhuang01