Fix memory leak via oldProps #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Mar 19, 2018
| @@ -449,6 +443,8 @@ export default class Layer { | |||
| } | |||
|
|
|||
| this.clearChangeFlags(); | |||
| // Release old props for GC once update is complete | |||
| this.oldProps = EMPTY_PROPS; | |||
There was a problem hiding this comment.
If we do this, do we actually need to store them on the layer? If we keep them around and trigger another diff, we'll get incorrect results, so we might as well not store them at all? Is there any other reason to keep them around?
There was a problem hiding this comment.
layerManager assigns oldProps outside of the layer, which is later used by shouldUpdateState and updateState. For minimum change we have to keep the field around.
There was a problem hiding this comment.
I agree that it should not be necessary.
ibgreen
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1548
Change List
layer.oldPropsonce update is completeTests: node, browser, layer-browser