Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add billboard option #2846

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Add billboard option #2846

merged 4 commits into from
Mar 29, 2019

Conversation

xintongxia
Copy link
Contributor

@xintongxia xintongxia commented Mar 27, 2019 •
edited

Background

Change List

  • Add billboard option in both TextLayer and IconLayer, default to true - facing camera as the old code, so this should not impact the users.
  • Add render test

billboard

Pessimistress
Pessimistress reviewed Mar 28, 2019
View reviewed changes
docs/layers/icon-layer.md Outdated Show resolved Hide resolved
modules/layers/src/icon-layer/icon-layer-vertex.glsl.js Outdated Show resolved Hide resolved
test/render/test-cases.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 29, 2019 •
edited

Coverage Status

Coverage decreased (-0.001%) to 60.86% when pulling 091047b on xx/billboard into 0ed3cbb on master.

@xintongxia xintongxia merged commit 125138a into master Mar 29, 2019
@xintongxia xintongxia deleted the xx/billboard branch March 29, 2019 16:29
@SymbolixAU SymbolixAU mentioned this pull request Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xintongxia @coveralls @Pessimistress