Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gallery examples #2958

Merged
merged 1 commit into from Apr 12, 2019
Merged

Fix gallery examples #2958

merged 1 commit into from Apr 12, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Rename dev bundle to dist.dev.js
  • Update reference in gallery start-local script
  • Fix point cloud standalone example

ibgreen
ibgreen approved these changes Apr 12, 2019
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a strong reason for using the dev bundle in the examples? I am assuming it slows down the loading of those considerably as it is several megabytes bigger.

@Pessimistress
Copy link
Collaborator Author

We're not using the dev bundle when published, the setting is for local debug.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.456% when pulling 8d4bda8 on x/bundle into f5a8c43 on master.

@Pessimistress Pessimistress merged commit ee0ddb8 into master Apr 12, 2019
@Pessimistress Pessimistress deleted the x/bundle branch April 12, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pessimistress @coveralls @xintongxia @ibgreen