New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep Attribute class for partial update #3091
Conversation
@@ -170,6 +170,11 @@ export default class Attribute extends BaseAttribute { | |||
|
|||
this.constant = false; | |||
this.value = new ArrayType(this.size * allocCount); | |||
|
|||
if (this.buffer && this.buffer.byteLength < this.value.byteLength) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to know ahead of time in that incremental case what the total size of the data will be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, no.
Alternatively, every time overflow happens, we could over-allocate the buffer instead of setting it to the exact new size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me. Something like doubling the size of the buffer on each overflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How sensitive should we be regarding GPU memory usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be a problem on mobile, but I think we have some leeway because we don't use textures much. It would be helpful to profile some typical use cases and see what our current memory usage is like.
ef9f4ba
to
77b481f
Compare
For #1576
Change List