Improve H3HexagonLayer perf #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
approved these changes
May 16, 2019
Closed
added 2 commits
May 16, 2019 15:28
Pessimistress
force-pushed
the
x/h3-hexagon-perf
branch
from
b3be36c
to
a177366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The current implementation of
H3HexagonLayerupdates the instanced geometry (regenerating attributes and creating new WebGL buffers) whenever the hexagon at the center of the viewport changes. This is excessive especially at fine resolutions.This PR introduces a distance threshold within which we consider all hexagons having the same shape. This significantly reduces the number of attribute updates needed when interacting with the viewport.
Change List