Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer-browser: Static scenegraph example #3129

Closed
wants to merge 3 commits into from
Closed

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented May 21, 2019

For #3130

  • Using ScenegraphLayer with non-URL scenegraphs appears broken.
  • This PR reproduces the issue in the layer browser.

@georgios-uber
Copy link
Contributor

@ibgreen are you still working on this? If not please close.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Jun 28, 2019

I was thinking about updating this to use the GLTFLoader - no need to mess with the gl context.

Would that be valuable?

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ georgios-uber
❌ Ib Green


Ib Green seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Pessimistress Pessimistress deleted the ib/scenegraph-example branch November 25, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants