Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code from scenegraph-layer shader #3167

Merged
merged 1 commit into from May 31, 2019
Merged

Remove dead code from scenegraph-layer shader #3167

merged 1 commit into from May 31, 2019

Conversation

georgios-uber
Copy link
Contributor

No description provided.

@georgios-uber georgios-uber self-assigned this May 31, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.947% when pulling 5536e1b on dead-code into eaf5b20 on master.

ibgreen
ibgreen approved these changes May 31, 2019
View reviewed changes
modules/mesh-layers/src/scenegraph-layer/scenegraph-layer.js
}
},
// tangents are not supported
useTangents: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed after cutting out all tangent code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some code inside the luma module.

@georgios-uber georgios-uber merged commit a9b6dd0 into master May 31, 2019
@georgios-uber georgios-uber deleted the dead-code branch May 31, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees

@georgios-uber georgios-uber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgios-uber @coveralls @ibgreen