Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer browser perf and bug fixes #3220

Merged
merged 2 commits into from Jun 11, 2019
Merged

Layer browser perf and bug fixes #3220

merged 2 commits into from Jun 11, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Separate state handling and layer generation into two components (no longer re-renders examples on view state change and/or hover)
  • Fix OrbitView usage
  • Fix MapView bug with position

@coveralls
Copy link

coveralls commented Jun 10, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 64.029% when pulling f33dde7 on x/layer-browser-perf into 2a9fe8f on master.

xintongxia
xintongxia approved these changes Jun 10, 2019
View reviewed changes
examples/layer-browser/src/map.js Outdated Show resolved Hide resolved
examples/layer-browser/src/map.js Outdated Show resolved Hide resolved
@Pessimistress Pessimistress merged commit a4d1634 into master Jun 11, 2019
@Pessimistress Pessimistress deleted the x/layer-browser-perf branch August 2, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

@1chandu 1chandu Awaiting requested review from 1chandu

@georgios-uber georgios-uber Awaiting requested review from georgios-uber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @xintongxia