Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadow effect RFC #3350

Merged
merged 8 commits into from Jul 22, 2019
Merged

shadow effect RFC #3350

merged 8 commits into from Jul 22, 2019

Conversation

jianhuang01
Copy link
Contributor

For #3341

Change List

  • RFC doc

@coveralls
Copy link

coveralls commented Jul 15, 2019 •
edited

Coverage Status

Coverage increased (+1.6%) to 83.824% when pulling 0352fb9 on shadow-rfc into f357a6d on master.

@jianhuang01 jianhuang01 merged commit 581ba9c into master Jul 22, 2019
@jianhuang01 jianhuang01 deleted the shadow-rfc branch July 22, 2019 22:29
ajduberstein pushed a commit that referenced this pull request Aug 1, 2019
@jianhuang01
shadow effect RFC (#3350)
762ded4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

@tsherif tsherif Awaiting requested review from tsherif

@1chandu 1chandu Awaiting requested review from 1chandu

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jianhuang01 @coveralls @Pessimistress