Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename frustum plane properties #3378

Merged
merged 1 commit into from Jul 26, 2019
Merged

Rename frustum plane properties #3378

merged 1 commit into from Jul 26, 2019

Conversation

Pessimistress
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.387% when pulling 1a8d9ff on x/frustum-naming into 0e5b1ac on master.

ibgreen
ibgreen approved these changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't there also an example that uses these fields?

@Pessimistress
Copy link
Collaborator Author

Wasn't there also an example that uses these fields?

That is the test app, already included in this PR

@Pessimistress Pessimistress merged commit 2e34e27 into master Jul 26, 2019
@Pessimistress Pessimistress deleted the x/frustum-naming branch July 26, 2019 22:56
ajduberstein pushed a commit that referenced this pull request Aug 1, 2019
@Pessimistress
Rename frustum plane properties (#3378)
a6b4c04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@tsherif tsherif Awaiting requested review from tsherif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @ibgreen