Remove side effects from core module

[Pessimistress]

Background

Per discussion in #3213, sideEffects is not sufficient to prevent tree shaking in some use cases.

Change List

• Wrap global registration in a function

Tested with build-bundle script.

[coveralls]

Coverage increased (+0.009%) to 83.014% when pulling e77402c on x/no-side-effects into ca074e2 on master.

[ibgreen]

The source code structure becomes a little weird this way.

Unless we think we can get the global inits working again later, I wonder if we should just move those init functions into deck.js (or at least lib folder).

I could see some issues in that one might for instance want to call loaders.gl load on something before creating deck and now one does get different loaders before and after deck is instantiated.

But this is still the lesser evil, as we have get this darned tree-shaking issue fixed...

[Pessimistress]

I could see some issues in that one might for instance want to call loaders.gl load on something before creating deck and now one does get different loaders before and after deck is instantiated.

That's fair; I have pushed an alternative approach. It should make no change to the current behavior.

[SterlingMcCall]

Due to the fact that this was/is a rather inconvenient bug for those affected, would it be possible to release this fix as version 7.1.11 so we don't have to wait until the release of 7.2.0?