New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json: minimap as pure json example #3563
Conversation
"y": "5%", | ||
"clear": true, | ||
"viewState": { | ||
"id": "dummy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main?
There is a known bug in https://github.com/uber/deck.gl/blob/master/modules/core/src/lib/deck.js#L743 where the ViewManager is updated without view id. A fix (breaking change) is scheduled for v8 unless this is affecting your use case. |
Not sure if it is worth a breaking change. I do think our multiview support is a pretty impressive feature of deck.gl but I don't think many users realize how easy it is to use. So I do think a JSON example that shows this is worth something. I am not sure I see how the modified view state from the minimap makes it back to the view manager, but assuming this is indeed the problem, perhaps we could do a temporary non-breaking fix by checking for another |
"type": "MapView", | ||
"id": "main", | ||
"mapStyle": "mapbox://styles/mapbox/dark-v9", | ||
"controller": "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Will do in followup.
For #3557
Background
@Pessimistress