Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: minimap as pure json example #3563

Merged
merged 2 commits into from Sep 11, 2019
Merged

json: minimap as pure json example #3563

merged 2 commits into from Sep 11, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 10, 2019

For #3557

Background

  • New example that uses declarative view api to set up minimap

@Pessimistress

  • I get this working to 95% but still an issue where the view stats snaps back...
  • maybe you can help me assess if there is a way to fix this with current API, if this is a bug, or if we'd need to make changes to make this work.

Screen Shot 2019-09-10 at 1 07 53 PM

@coveralls
Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage increased (+2.9%) to 82.471% when pulling 03c933e on ib/json-minimap-example into 35c0d45 on master.

"y": "5%",
"clear": true,
"viewState": {
"id": "dummy",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main?

@Pessimistress
Copy link
Collaborator

still an issue where the view stats snaps back

There is a known bug in https://github.com/uber/deck.gl/blob/master/modules/core/src/lib/deck.js#L743 where the ViewManager is updated without view id. A fix (breaking change) is scheduled for v8 unless this is affecting your use case.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Sep 10, 2019

There is a known bug in /modules/core/src/lib/deck.js@master#L743 where the ViewManager is updated without view id. A fix (breaking change) is scheduled for v8 unless this is affecting your use case.

Not sure if it is worth a breaking change. I do think our multiview support is a pretty impressive feature of deck.gl but I don't think many users realize how easy it is to use. So I do think a JSON example that shows this is worth something.

I am not sure I see how the modified view state from the minimap makes it back to the view manager, but assuming this is indeed the problem, perhaps we could do a temporary non-breaking fix by checking for another viewState.noupdate flag and avoid calling the offending like if detected?

"type": "MapView",
"id": "main",
"mapStyle": "mapbox://styles/mapbox/dark-v9",
"controller": "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop quotes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Will do in followup.

@ibgreen ibgreen merged commit 8a6805c into master Sep 11, 2019
@ibgreen ibgreen deleted the ib/json-minimap-example branch September 11, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants