Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydeck layer docs #3655

Merged
merged 3 commits into from Sep 23, 2019
Merged

Conversation

@ajduberstein
Copy link
Contributor

ajduberstein commented Sep 19, 2019

For #3640

Background

Change List

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 19, 2019

Coverage Status

Coverage decreased (-2.9%) to 79.802% when pulling 89e398d on ajduberstein-patch-1-update-layer-docs into ffc2cb3 on master.

bindings/python/pydeck/docs/layer.md Outdated Show resolved Hide resolved
bindings/python/pydeck/docs/layer.md Outdated Show resolved Hide resolved
bindings/python/pydeck/docs/layer.md Outdated Show resolved Hide resolved
bearing=0
)
polygon = pydeck.Layer(

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Sep 20, 2019

Contributor

This layer is there for the shadow effect. Is there away for pydeck users to specify lighting?

This comment has been minimized.

Copy link
@ajduberstein

ajduberstein Sep 21, 2019

Author Contributor

There is, using the wrapper around deck.gl's LightSettings: https://github.com/uber/deck.gl/blob/master/bindings/python/pydeck/pydeck/bindings/light_settings.py, I can add this to the example and document it as well

@ajduberstein ajduberstein merged commit 7ae4e8e into master Sep 23, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
@ajduberstein ajduberstein deleted the ajduberstein-patch-1-update-layer-docs branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.