Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydeck layer docs #3655

Merged
merged 3 commits into from Sep 23, 2019
Merged

Conversation

ajduberstein
Copy link
Collaborator

For #3640

Background

Change List

@coveralls
Copy link

coveralls commented Sep 19, 2019

Coverage Status

Coverage decreased (-2.9%) to 79.802% when pulling 89e398d on ajduberstein-patch-1-update-layer-docs into ffc2cb3 on master.

bindings/python/pydeck/docs/layer.md Outdated Show resolved Hide resolved
bindings/python/pydeck/docs/layer.md Outdated Show resolved Hide resolved
bindings/python/pydeck/docs/layer.md Outdated Show resolved Hide resolved
bearing=0
)

polygon = pydeck.Layer(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This layer is there for the shadow effect. Is there away for pydeck users to specify lighting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is, using the wrapper around deck.gl's LightSettings: https://github.com/uber/deck.gl/blob/master/bindings/python/pydeck/pydeck/bindings/light_settings.py, I can add this to the example and document it as well

@ajduberstein ajduberstein merged commit 7ae4e8e into master Sep 23, 2019
@ajduberstein ajduberstein deleted the ajduberstein-patch-1-update-layer-docs branch December 9, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants