Fix bugs in pre-bundled version #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xintongxia
approved these changes
Sep 20, 2019
Merged
ibgreen
reviewed
Sep 21, 2019
| @@ -8,5 +8,7 @@ const deck = _global.deck || {}; | |||
| if (!deck.LineLayer) { | |||
| throw new Error('@deck.gl/layers is not found'); | |||
| } | |||
| // Merge experimental exports | |||
| Object.assign(deckGLLayers.experimental, deck.experimental); | |||
There was a problem hiding this comment.
If the variable was called aggregationLayers I would have been less confused...
Didn't we drop experimental export in favor of underscores?
There was a problem hiding this comment.
We moved classes to underscore but kept utility functions in the experimental object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List
experimentalexports from core and aggregation-layersBuffer is undefinederror, see Fix core module browser config loaders.gl#422