Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs #4428

Merged
merged 1 commit into from Apr 1, 2020
Merged

fix docs #4428

merged 1 commit into from Apr 1, 2020

Conversation

damix911
Copy link
Collaborator

Address an error in the docs for FirstPersonView where the pitch angle 90 was deemed "up" and -90 was deemed "down", while it's actually the opposite, which for mapping makes sense.

@damix911
Copy link
Collaborator Author

@Pessimistress FIY.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.64% when pulling 592e13c on damix911:ddamico/fix-fpv-updown-md into 621bcb9 on uber:master.

Pessimistress
Pessimistress approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pessimistress Pessimistress merged commit 44447f2 into visgl:master Apr 1, 2020
Pessimistress pushed a commit that referenced this pull request Apr 26, 2020
@damix911 @Pessimistress
fix docs (#4428)
db3b4e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damix911 @coveralls @Pessimistress