Fix the layer tests on node #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
May 24, 2017
|
@ibgreen yeah... you are right. It's not needed. The real problem is |
howtimeflies0
force-pushed
the
fix-layer-test-node
branch
3 times, most recently
from
c8f2ff9
to
d69a239
Compare
ericsoco
force-pushed
the
fix-layer-test-node
branch
from
d69a239
to
b07dac1
Compare
|
Just tested locally after rebasing on master, looks good. Pushed the rebase up. Merge at will |
ericsoco
approved these changes
May 24, 2017
Firenze11
pushed a commit
to Firenze11/deck.gl
that referenced
this pull request
May 31, 2017
* Require setup-gl.js in test-dist.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that headless GL context is not created properly on node