Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer.parameters: Update docs and forward prop in GeojsonLayer #874

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Layer.parameters: Update docs and forward prop in GeojsonLayer #874

merged 1 commit into from
Aug 23, 2017

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 23, 2017

No description provided.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Aug 23, 2017

See #873

@ibgreen ibgreen added this to the v4.1 PATCH milestone Aug 23, 2017
@ibgreen
Copy link
Collaborator Author

ibgreen commented Aug 23, 2017

@georgios-uber

@georgios-uber georgios-uber merged commit 3d1dd14 into master Aug 23, 2017
@georgios-uber
Copy link
Contributor

Great

@georgios-uber georgios-uber deleted the 0823-parameters branch August 23, 2017 21:48
@georgios-uber
Copy link
Contributor

Great

@1chandu
Copy link
Contributor

1chandu commented Aug 23, 2017

@ibgreen looks good, thanks for taking care of this.

One thing I notices when looking into layer.js , this.props is never used, but then I saw , layer.props.parameters are passed back to drawLayer method, which was bit confusing. May be we should only pass any extra parameters to this method and then merge them with this.parameters.

@ibgreen ibgreen mentioned this pull request Aug 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howtimeflies0 howtimeflies0 Awaiting requested review from howtimeflies0

@1chandu 1chandu Awaiting requested review from 1chandu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1.2 PATCH
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ibgreen @georgios-uber @1chandu