Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetToLinkedGeo bug and update to latest C library #49

Merged
merged 2 commits into from Dec 1, 2021
Merged

SetToLinkedGeo bug and update to latest C library #49

merged 2 commits into from Dec 1, 2021

Conversation

retbrown
Copy link
Contributor

This PR correctly sets Next in the linkedGeoPolygonFromC function as identified by @asmeikal in issue #47.

Additionally bumps the C h3 library version for the v3 version to 3.7.2

@coveralls
Copy link

coveralls commented Jul 31, 2021 •
edited

Pull Request Test Coverage Report for Build 1085161429

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 655022339: 0.0%
Covered Lines: 278
Relevant Lines: 278
💛 - Coveralls

jogly
jogly approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test!

@jogly jogly merged commit 22412b0 into uber:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@jogly jogly jogly approved these changes

@isaacbrodsky isaacbrodsky isaacbrodsky approved these changes

@dfellis dfellis Awaiting requested review from dfellis

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@retbrown @coveralls @nrabinowitz @jogly @isaacbrodsky