Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add h3ToIj #102

Merged
merged 18 commits into from
Oct 3, 2018
Merged

Add h3ToIj #102

merged 18 commits into from
Oct 3, 2018

Commits on Jul 26, 2018

  1. Add h3ToIj 

    h3ToIj wraps the internal function h3ToIjk and produces a two-dimensional
IJ coordinate system. It has the same limitations of h3ToIjk regarding
cells too far away from the origin or across pentagonal distortion.
    Isaac Brodsky committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    5abcf1e View commit details
    Browse the repository at this point in the history

  2. Fix whitespace in CMakeLists.txt

    Isaac Brodsky committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    09a3bce View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. Add additional comments about failure cases

    Isaac Brodsky committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    9e52b63 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Adjust comments in testH3ToIj.c per review

    Isaac Brodsky committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    1204338 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into h3-to-ij

    Isaac Brodsky committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    60da119 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Rename h3ToIj to experimentalH3ToLocalIj 

    The function is renamed to indicate it's experimental, and the
suite of functions is refactored to its own `localij.c` module.
    Isaac Brodsky committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    b81299d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into h3-to-ij

    Isaac Brodsky committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    d1927f8 View commit details
    Browse the repository at this point in the history

  3. Add h3ToLocalIj to CHANGELOG

    Isaac Brodsky committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    62863a4 View commit details
    Browse the repository at this point in the history

  4. Cleanup refactoring to localij.h

    Isaac Brodsky committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    1170719 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into h3-to-ij

    Isaac Brodsky committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    ffc1b32 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Add experimentalLocalIjToH3

    Isaac Brodsky committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    974b3f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into h3-to-ij

    Isaac Brodsky committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    bac0ad1 View commit details
    Browse the repository at this point in the history

  3. Fix capitalization of localij.h

    Isaac Brodsky committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    9ff9d20 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Fix undefined handling of deleted base cell 

    Passing INVALID_BASE_CELL caused a lookup beyond the table, and
thus undefined behavior. The behavior should always be to treat
the base cell as not a pentagon in that case.
    Isaac Brodsky committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    a2b720d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Add tests for out of range local IJ coordinates, assert unrotated dir… 

    …ection is not K_AXES_DIGIT.
    Isaac Brodsky committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    d722df2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Add test for traversing the local IJ space

    Isaac Brodsky committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    3671b4e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. Adjust comments and test assertion messages based on feedback. 

    Normalized test assertion messages to assert a positive outcome.
    Isaac Brodsky committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    b982cb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. Remove check for the mode of indexes in h3ToLocalIjk 

    Tests are updated to assume that unidirectional edges are treated as their origin by this function.

There does not appear to be a case where finding the IJK of the origin itself would fail, so the line checking for that in h3Distance is excluded from coverage.
    Isaac Brodsky committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    8cd83bb View commit details
    Browse the repository at this point in the history