add haversine distance calc example #22
Conversation
|
|
adds an example for referencing in issue uber#18
jogly
force-pushed
the
jg-distance-example
branch
from
87042d4
to
088d905
Compare
examples/distance.c
Outdated
| #include <math.h> | ||
| #include <stdio.h> | ||
|
|
||
| double dist(double th1, double ph1, double th2, double ph2) { |
There was a problem hiding this comment.
Since this is an example, maybe include a comment on the algo here with a link to some reference?
There was a problem hiding this comment.
Also, would it be better to just expose _geoDistRads or _geoDistKm from geoCoord?
There was a problem hiding this comment.
could do! i expect cutting out the middle step and creating h3DistKm would be more valuable and appropriate for this lib, since that's what I'm doing here anyway, but cross that bridge if/when we find the need?
There was a problem hiding this comment.
maybe include a comment on the algo here
done!
examples/distance.c
Outdated
| @@ -0,0 +1,61 @@ | |||
| /* | |||
| * Copyright 2017 Uber Technologies, Inc. | |||
examples/distance.c
Outdated
| #include <math.h> | ||
| #include <stdio.h> | ||
|
|
||
| double dist(double th1, double ph1, double th2, double ph2) { |
There was a problem hiding this comment.
Add a comment for this function? What are the parameters, is it Haversine distance, etc?
There was a problem hiding this comment.
Looks OK to me; @nrabinowitz raises a good point about publicizing geoDistRads/geoDistKm, but I think this is fine considering the haversine formula seems to be well documented online.
examples/distance.c
Outdated
| // 555 Market St @ resolution 15 | ||
| H3Index h3HQ2 = stringToH3("8f283082a30e623"); | ||
|
|
||
| double distance = 0; |
There was a problem hiding this comment.
Looks like double distance is not used.
There was a problem hiding this comment.
uh oh, possible to configure linter to catch? compiling with -Wall catches this...
There was a problem hiding this comment.
publicizing geoDistRads/geoDistKm
I suggest we put out a minor version feature bump with these two and h3DistRads/h3DistKm; doing that is out of scope for this addition. like I mentioned to @nrabinowitz , I expect the h3 distance functions will be more useful and appropriate than yet another set of geo distance functions.
jogly
force-pushed
the
jg-distance-example
branch
from
effbedb
to
c81c042
Compare
|
Making |
|
created #23 for tracking |
add haversine distance calc example
adds an example for referencing in issue #18