Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h3 flutter #578

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Add h3 flutter #578

merged 2 commits into from
Feb 20, 2022

Conversation

festelo
Copy link
Contributor

@festelo festelo commented Feb 18, 2022

https://github.com/festelo/h3_flutter provides bindings to C version of H3 for Flutter.

There are bindings for 40 methods from H3 - https://pub.dev/documentation/h3_flutter/latest/h3_flutter/H3-class.html
And 2 methods from geo2json - h3SetToFeatureCollection and h3ToFeature.

All these methods are covered by unit tests (which mostly were ported from h3-js lib)

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2022

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Feb 18, 2022

Coverage Status

Coverage remained the same at 98.653% when pulling c1124c0 on festelo:patch-1 into 8bd135b on uber:master.

@nrabinowitz
Copy link
Collaborator

Awesome, thanks for the contribution!

@@ -32,6 +32,10 @@ As a C library, bindings can be made to call H3 functions from different program
## Clojure

- [Factual/geo](https://github.com/Factual/geo)
-
## Dart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity (I don't know the ecosystem very well) - would it make more sense for this to go under Flutter? I can see Flutter is written in Dart, but can you use these bindings in arbitrary Dart projects, or just Flutter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in current state the bindings can't be used outside of Flutter projects.
Although, it's not really difficult to make it work under Dart VM, need to reorganize structure a little, split the package on 2 different ones.
So maybe it's temporary :)

I think 'Dart' title is more appropriate here than Flutter, because there's JavaScript section which contains 3 links - for pure JS, node JS and React Native.
JS - RN, Dart - Flutter, similar.

website/docs/community/bindings.md Outdated Show resolved Hide resolved
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
@isaacbrodsky isaacbrodsky merged commit f8a0a84 into uber:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants