Fix possible signed integer overflow in ijToIjk #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
approved these changes
Dec 5, 2022
|
CI seems to be failing due presumably unrelated error about |
This was referenced Dec 5, 2022
isaacbrodsky
force-pushed
the
fix-ijtoijk-signed-integer-overflow
branch
from
2c018ce
to
1309956
Compare
|
The fuzzer failure looks like an unrelated flaky fuzzer on polygonToCells |
dfellis
approved these changes
Dec 7, 2022
|
Closing this in favor of using macros in #735. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #706.