Fix cellToChildPos and childPosToCell docs #845
Merged
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's currently on the website:
After the fix:
|
isaacbrodsky
approved these changes
Jun 4, 2024
nrabinowitz
approved these changes
Jun 4, 2024
| @@ -6263,6 +6263,14 @@ react-loadable-ssr-addon-v5-slorber@^1.0.1: | |||
| dependencies: | |||
| "@babel/runtime" "^7.10.3" | |||
|
|
|||
| "react-loadable@npm:@docusaurus/react-loadable@5.5.2": | |||
There was a problem hiding this comment.
Seems a little odd that the lockfile would change here (different yarn version maybe?) but NBD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while going through the H3 documentation working on the cli that the live examples for the
cellToChildPosandchildPosToCelldon't work because the website is using an out of date version of h3-js. This small PR fixes that (confirmed locally).