Skip to content

Commit

Permalink
Make duplicate name test more robust (#762)
Browse files Browse the repository at this point in the history
* Make duplicate name test more robust

* Resolve ~/.keras issue as well
  • Loading branch information
alsrgv committed Jan 15, 2019
1 parent de4cc08 commit 0700dcf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ script:
fi
# prepare ~/.keras folder to avoid race condition
- docker exec ${CONTAINER} /bin/sh -c "mkdir -p ~/.keras"

# run unit tests
- docker exec ${CONTAINER} /bin/sh -c "pip install pytest && cd /horovod/test && (echo test_*.py | xargs -n 1 ${MPIRUN} pytest -v)"

Expand Down
9 changes: 6 additions & 3 deletions test/test_torch.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,8 @@ def test_horovod_allreduce_duplicate_name_error(self):

hvd.allreduce_async(tensor, name='duplicate_name')
try:
hvd.allreduce_async(tensor, name='duplicate_name')
for i in range(10):
hvd.allreduce_async(tensor, name='duplicate_name')
assert False, 'hvd.allreduce_async did not throw error'
except (torch.FatalError, ValueError):
pass
Expand Down Expand Up @@ -560,7 +561,8 @@ def test_horovod_allgather_duplicate_name_error(self):

hvd.allgather_async(tensor, name='duplicate_name')
try:
hvd.allgather_async(tensor, name='duplicate_name')
for i in range(10):
hvd.allgather_async(tensor, name='duplicate_name')
assert False, 'hvd.allgather_async did not throw error'
except (torch.FatalError, ValueError):
pass
Expand Down Expand Up @@ -757,7 +759,8 @@ def test_horovod_broadcast_duplicate_name_error(self):

hvd.broadcast_async(tensor, root_rank=0, name='duplicate_name')
try:
hvd.broadcast_async(tensor, root_rank=0, name='duplicate_name')
for i in range(10):
hvd.broadcast_async(tensor, root_rank=0, name='duplicate_name')
assert False, 'hvd.broadcast_async did not throw error'
except (torch.FatalError, ValueError):
pass
Expand Down

0 comments on commit 0700dcf

Please sign in to comment.