-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support preheat when using registry as backend #147
Conversation
Would you mind updating the PR description with a change summary, including:
|
#145 changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the change looks pretty reasonable to me. I'm fine holding off on tests until the review stabilizes, but we should add some before this lands.
@codygibb i have updated as your comment. please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, just needs some clean up. Let's add some tests (I think agent/agentserver/server_test.go
is a good example to work off of).
additional, i used to think the http server in proxy is mandatory. |
Agreed. Let's keep it optional in this diff, but I'll make it required in a follow up diff and fix anything that breaks. |
Signed-off-by: peimingming <peimingming@corp.netease.com>
Signed-off-by: peimingming <peimingming@corp.netease.com>
it seems the fossa makes build failed. i have modified PR by your comments. and test is OK too including the log format. i will add some UT and raised a new PR later. |
Yeah the fossa integration is broken right now. Feel free to ignore for now. |
Signed-off-by: peimingming <peimingming@corp.netease.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look great! Thank you for putting this together!
@yiranwang52