Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenedByRemote should be false for local #163

Merged
merged 1 commit into from
May 30, 2019

Conversation

mmpei
Copy link
Contributor

@mmpei mmpei commented May 24, 2019

when connection opened by local peer, the flag 'openedByRemote' in Conn should be false.
see log
2019-05-24T11:03:56.639Z INFO scheduler/events.go:219 Added outgoing conn with 0% downloaded {"conn": "Conn(peer=c5399c8209e12a1df3e2bf8271661cc7ec9d44d8, hash=68aecd38087eb91de8a9a356ea9b8d6808f700f7, opened_by_remote=true)"}
it will make people confused.

Signed-off-by: mmpei <peimingming@corp.netease.com>
@yiranwang52 yiranwang52 merged commit 938f31c into uber:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants