Add GCS backend #180

rmalpani-uber · 2019-06-13T00:54:03Z

Mock tests

CLAassistant · 2019-06-13T00:54:10Z

All committers have signed the CLA.

lib/backend/constants.go

lib/backend/gcsbackend/client.go

+ Config example for GCS backend + Mock tests for GCS backend

yiranwang52 · 2019-06-14T23:15:49Z

lib/backend/constants.go

+)
+
+const (
+DefaultPartSize    int64             = int64(64 * memsize.MB)


I think you need a tab before this?

evelynl94 requested a review from codygibb June 13, 2019 18:03

yiranwang52 reviewed Jun 14, 2019

View reviewed changes

lib/backend/constants.go Outdated Show resolved Hide resolved

lib/backend/gcsbackend/client.go Outdated Show resolved Hide resolved

Summary: Add GCS backend

0cdc513

+ Config example for GCS backend + Mock tests for GCS backend

yiranwang52 approved these changes Jun 14, 2019

View reviewed changes

lib/backend/constants.go

)

const (

DefaultPartSize int64 = int64(64 * memsize.MB)

Copy link

Collaborator

yiranwang52 Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a tab before this?

yiranwang52 changed the title ~~Summary: Add GCS backend~~ Add GCS backend Jun 17, 2019

yiranwang52 merged commit 7ff50aa into uber:master Jun 17, 2019

This was referenced Jun 17, 2019

Add GCS backend #44

Closed

Fix GCS backend code format and update docs #181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GCS backend #180

Add GCS backend #180

rmalpani-uber commented Jun 13, 2019

CLAassistant commented Jun 13, 2019 •

edited

yiranwang52 Jun 14, 2019

Add GCS backend #180

Add GCS backend #180

Conversation

rmalpani-uber commented Jun 13, 2019

CLAassistant commented Jun 13, 2019 • edited

yiranwang52 Jun 14, 2019

Choose a reason for hiding this comment

CLAassistant commented Jun 13, 2019 •

edited