Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with weather example #649

Closed
rogeriosmorais opened this issue Mar 7, 2020 · 1 comment
Closed

Bug with weather example #649

rogeriosmorais opened this issue Mar 7, 2020 · 1 comment
Labels
documentation improve documentation

Comments

@rogeriosmorais
Copy link

Hi guys, I know this is very small and probably just a typo, but the example given in https://uber.github.io/ludwig/examples/#time-series-forecasting-weather-data-example, in the pre-processing portion of the provided code there's SPLIT in 3 different points, but that doesn't run as it is. I suppose it was meant to create a new column in the dataframe, if that's the case it should be 'SPLIT', not SPLIT. I was able to run it without any problems after making that small change. Just suggestion to update the documentation.

@w4nderlust
Copy link
Collaborator

Thanks for noticing! SPLIT is a constant in Ludwig that is SPLIT = 'split'. So I'll change to either import the constant or replace with the string. Thank you.

@w4nderlust w4nderlust added the documentation improve documentation label Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improve documentation
Projects
None yet
Development

No branches or pull requests

2 participants