Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glTF/PBR: Add ability to switch between IBL and Regular Lights #985

Merged
merged 1 commit into from
Mar 14, 2019
Merged

glTF/PBR: Add ability to switch between IBL and Regular Lights #985

merged 1 commit into from
Mar 14, 2019

Conversation

georgios-uber
Copy link
Contributor

No description provided.

@georgios-uber georgios-uber self-assigned this Mar 14, 2019
ibgreen
ibgreen approved these changes Mar 14, 2019
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to get this example ready for prime time. Should it be full screen and have a nice control panel overlaid?

@georgios-uber georgios-uber merged commit 2266503 into master Mar 14, 2019
@georgios-uber georgios-uber deleted the ibl-lights-only branch March 14, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees

@georgios-uber georgios-uber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgios-uber @ibgreen