Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styletron engine doesn't need to be initiated again if embedded app is using styletron already #66

Closed
Firenze11 opened this issue Nov 12, 2019 · 0 comments · Fixed by #67

Comments

@Firenze11
Copy link

Summary

In app where styletron is already used, the styletron engine within manifold component will conflict with the engine outside.

Current Behavior

E.g. if the app uses server side rendering, it will conflict with the engine within manifold which uses client side rendering

ReferenceError: document is not defined
    at new StyletronClient (/Users/agreco/dev/michelangelo-web-fresh/node_modules/styletron-engine-atomic/dist/index.js:660:7)
    at Object. (/Users/agreco/dev/michelangelo-web-fresh/node_modules/@mlvis/src/components/manifold.js:35:16)

Possible Solution

Remove styletron engine from within manifold; ask users to use styletron provider separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant