Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website #77

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Fix website #77

merged 2 commits into from
Nov 26, 2019

Conversation

Firenze11
Copy link
Contributor

@Firenze11 Firenze11 commented Nov 26, 2019

Summary | Related Issue(s)

Website compilation erred. The reason could be that in #76, we imported "html-webpack-plugin": "^4.0.0-beta.8" which used terser-webpack-plugin. From webpack-contrib/terser-webpack-plugin#119 it seems that is the cause for the error. Used newer version of Terser fixes the issue.

Changes

  1. Changed node environment in website/ to be aligned with root
  2. Explicitly installed "terser-webpack-plugin": "^2.2.1"
  3. Reinstalled and updated yarn.lock files

Test Plan

Test website to be working

Checklist

  • I have made this PR atomic.
  • I have provided enough context for others to review.
  • [ ] I have added tests to cover my changes (for features and bug fixes).
  • [ ] I have updated the documentation and changelogs accordingly.
  • All new and existing tests passed.

@Firenze11 Firenze11 merged commit 9824f14 into master Nov 26, 2019
@Firenze11 Firenze11 deleted the fix-website branch November 26, 2019 23:22
@gnavvy gnavvy mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants