Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReturnSelf] Allows Protocols to Return Self #118

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

tinder-maxwellelliott
Copy link
Contributor

@tinder-maxwellelliott tinder-maxwellelliott commented Jul 28, 2020

Currently Mockolo is broken for Protocols that return Self. These changes ensure that we return the mock class type when we encounter a Self return type:

Example protocol that breaks Mockolo currently

/// @mockable
protocol NonSimpleFuncs {
    @discardableResult
    func returnSelf() -> Self
}

Currently Mockolo is broken fro Protocols that return Self. These changes ensure that we return the mock class type when we encounter a Self return type
@elsh
Copy link
Contributor

elsh commented Aug 7, 2020

thanks for the change

@elsh elsh merged commit 26ce5db into uber:master Aug 7, 2020
uhooi pushed a commit to uhooi/mockolo that referenced this pull request Apr 27, 2021
…return_type

[ReturnSelf] Allows Protocols to Return Self
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants