Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swift-argument-parser dependency #197

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Update swift-argument-parser dependency #197

merged 2 commits into from
Aug 26, 2022

Conversation

pablocornejo
Copy link
Contributor

Overview

  • Support Swift 5.6 #178 added Swift 5.6 support, but f38ae33 limited the version flexibility of the swift-argument-parser dependency. The reasoning for this is explained in this comment.
  • This makes package resolution for other packages that have Mockolo as a dependency less flexible. So, to have the same flexibility as before f38ae33, but still account for the issue mentioned in the comment linked above, the version range of the swift-argument-parser dependency is being made dependent on the Swift version.

@AndrewSB
Copy link

@uhooi i'd love to see this un-pinned

@uhooi uhooi self-requested a review August 25, 2022 07:04
uhooi
uhooi requested changes Aug 25, 2022
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
@pablocornejo pablocornejo force-pushed the feature/update-swift-argument-parser branch from d659d63 to 360205f Compare August 26, 2022 02:42
uhooi
uhooi approved these changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@uhooi uhooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@uhooi uhooi merged commit 421fade into uber:master Aug 26, 2022
@pablocornejo pablocornejo deleted the feature/update-swift-argument-parser branch August 26, 2022 12:23
@pablocornejo
Copy link
Contributor Author

Thanks @uhooi, do you know what could be done to release a 1.7.1 version that includes this?

@uhooi
Copy link
Collaborator

uhooi commented Aug 27, 2022

I will now release.

@uhooi
Copy link
Collaborator

uhooi commented Aug 27, 2022

@pablocornejo Released!
https://github.com/uber/mockolo/releases/tag/1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhooi uhooi uhooi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pablocornejo @AndrewSB @uhooi