Merge 0198c88 into 34d72a9

modules/layers/src/layers/editable-layer.ts

@@ -35,7 +35,9 @@ export default class EditableLayer extends CompositeLayer<any> {
     // default implementation - do nothing
   }
 
-  onPointerMove(event: PointerMoveEvent) {} // default implementation - do nothing
+  onPointerMove(event: PointerMoveEvent) {
+    // default implementation - do nothing
+  }
   // TODO: implement onCancelDragging (e.g. drag off screen)
 
   initializeState() {
@@ -60,12 +62,19 @@ export default class EditableLayer extends CompositeLayer<any> {
     this._removePointerHandlers();
   }
 
+  // Adding an event handler for dblclick causes deck to debounce clicks. This method prevents
+  // an event handler for dblclick from being registered if onDoubleClick wasn't overridden.
+  _getActiveEventTypes() {
+    const isOnDoubleClickOverriden = this.onDoubleClick !== EditableLayer.prototype.onDoubleClick;
+    return isOnDoubleClickOverriden ? EVENT_TYPES : EVENT_TYPES.filter((t) => t !== 'dblclick');
+  }
+
   _addPointerHandlers() {
     // @ts-ignore
     const { eventManager } = this.context.deck;
     const { eventHandler } = this.state._editableLayerState;
 
-    for (const eventType of EVENT_TYPES) {
+    for (const eventType of this._getActiveEventTypes()) {
       eventManager.on(eventType, eventHandler, {
         // give nebula a higher priority so that it can stop propagation to deck.gl's map panning handlers
         priority: 100,
@@ -78,7 +87,7 @@ export default class EditableLayer extends CompositeLayer<any> {
     const { eventManager } = this.context.deck;
     const { eventHandler } = this.state._editableLayerState;
 
-    for (const eventType of EVENT_TYPES) {
+    for (const eventType of this._getActiveEventTypes()) {
       eventManager.off(eventType, eventHandler);
     }
   }