Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gatsby-remark-embedded-codesandbox for inline examples in docs #217

Merged
merged 1 commit into from May 6, 2019

Conversation

georgios-uber
Copy link
Contributor

No description provided.

@georgios-uber georgios-uber requested a review from ibgreen May 6, 2019 04:05
@georgios-uber georgios-uber self-assigned this May 6, 2019
@georgios-uber
Copy link
Contributor Author

Screen Shot 2019-05-05 at 9 02 59 PM

@georgios-uber
Copy link
Contributor Author

@ibgreen 2 problems:

  • How to resize?
  • Where to store mapbox token?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1019

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.973%

Totals Coverage Status
Change from base Build 1017: 0.0%
Covered Lines: 953
Relevant Lines: 1921

💛 - Coveralls

@ibgreen
Copy link
Collaborator

ibgreen commented May 6, 2019

This is awesome. Happy to accept this as standard feature in ocular-gatsby! @jckr

How to resize?

This seems to be part of the markdown system, so any resize would be handled by those plugins. We'll need to read up more on how this works?

Where to store mapbox token?

I believe @jianhuang01 implemented a token query in the build script for deck.gl. Let's check if that is easy to port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants