Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-map-gl-draw: use nebula.gl/edit-modes #376

Merged
merged 1 commit into from Apr 20, 2020
Merged

Conversation

xintongxia
Copy link
Collaborator

@xintongxia xintongxia commented Apr 4, 2020

This PR:

  • use draw point, string, polygon modes from @nebula.gl/edit-modes

Next PR:

  • deprecate react-map-gl-draw edit mode

@coveralls
Copy link

coveralls commented Apr 4, 2020

Pull Request Test Coverage Report for Build 1891

  • 8 of 106 (7.55%) changed or added relevant lines in 8 files are covered.
  • 864 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-15.3%) to 7.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/react-map-gl-draw/src/edit-modes/base-mode.ts 0 1 0.0%
modules/react-map-gl-draw/src/index.ts 0 1 0.0%
modules/react-map-gl-draw/src/style.ts 0 3 0.0%
modules/react-map-gl-draw/src/mode-handler.tsx 0 16 0.0%
modules/react-map-gl-draw/src/edit-modes/utils.ts 2 21 9.52%
modules/react-map-gl-draw/src/edit-modes/editing-mode.ts 0 29 0.0%
modules/react-map-gl-draw/src/editor.tsx 0 29 0.0%
Files with Coverage Reduction New Missed Lines %
modules/react-map-gl-draw/src/mode-handler.tsx 1 0%
modules/react-map-gl-draw/src/editor.tsx 4 0%
modules/edit-modes/src/lib/draw-rectangle-mode.ts 9 0%
modules/layers/src/layers/elevated-edit-handle-layer.ts 11 0%
modules/layers/src/math.ts 11 0%
modules/react-map-gl-draw/src/edit-modes/editing-mode.ts 11 0%
modules/edit-modes/src/memoize.ts 12 0%
modules/edit-modes/src/lib/draw-circle-by-diameter-mode.ts 16 0%
modules/edit-modes/src/lib/draw-line-string-mode.ts 22 0%
modules/edit-modes/src/lib/composite-mode.ts 23 0%
Totals Coverage Status
Change from base Build 1889: -15.3%
Covered Lines: 359
Relevant Lines: 4848

💛 - Coveralls

Copy link
Collaborator

@supersonicclay supersonicclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising it says there are no conflicts. You probably want to rebase on the TypeScript changes before merging.

@xintongxia xintongxia changed the title react-ma-gl-draw: use nebula.gl/edit-modes react-map-gl-draw: use nebula.gl/edit-modes Apr 19, 2020
@xintongxia xintongxia changed the base branch from xx/shape to master April 20, 2020 16:04
@xintongxia xintongxia changed the base branch from master to xx/shape April 20, 2020 16:05
@xintongxia xintongxia changed the base branch from xx/shape to master April 20, 2020 16:06
rebase and fix local webpack configs

remove generated files
@xintongxia xintongxia merged commit fb613f7 into master Apr 20, 2020
@xintongxia xintongxia deleted the xx/refactor-2 branch April 20, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants