Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize circle mode #521

Merged
merged 10 commits into from
Feb 10, 2021
Merged

Add resize circle mode #521

merged 10 commits into from
Feb 10, 2021

Conversation

StijnAmeloot
Copy link
Contributor

Added edit mode to resize an existing circular Polygon feature.

How it works:

  • Select a circular Polygon feature,
  • Click + hold and drag away from the center to increase the size of the feature,
  • Click + hold and drag inward to decrease the size of feature

Example
resize-circle-mode

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run yarn lint fix to get rid of the CI errors

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2280

  • 0 of 66 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 22.219%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/edit-modes/src/index.ts 0 1 0.0%
modules/main/src/index.ts 0 1 0.0%
modules/edit-modes/src/lib/resize-circle-mode.ts 0 64 0.0%
Totals Coverage Status
Change from base Build 2278: -0.3%
Covered Lines: 1218
Relevant Lines: 5188

💛 - Coveralls

@StijnAmeloot
Copy link
Contributor Author

#505

@ibgreen ibgreen requested a review from kargeor February 9, 2021 19:40
@ibgreen ibgreen merged commit eb49561 into uber:master Feb 10, 2021
@StijnAmeloot StijnAmeloot deleted the resize-circle-mode branch February 10, 2021 15:56
StijnAmeloot added a commit to StijnAmeloot/nebula.gl that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants