OkBuck is executing Dagger on tests even if it wasn't told to do so

[vanniktech]

This time with repro - https://github.com/vanniktech/okbuck-playground/pull/5

Is this by design?

[kageiit]

Definitely not by intelligent design, but more of a simplification made in the early days. This needs to be refactored to work like any other compile time dependency config by taking main/test/flavor/buildtype conventions into account

[vanniktech]

I think this might break ./buckw test for my project since building the app version using ./buckw build appDeug works. When executing ./buckw test, I get:

An exception has occurred in the compiler (1.8.0_60). Please file a bug at the Java Bug Database (http://bugreport.java.com/bugreport/) after checking the database for duplicates. Include your program and the following diagnostic in your report.  Thank you.
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found

An exception has occurred in the compiler (1.8.0_60). Please file a bug at the Java Bug Database (http://bugreport.java.com/bugreport/) after checking the database for duplicates. Include your program and the following diagnostic in your report.  Thank you.
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found

BUILD FAILED: //app:test_debug#testsjar failed with exit code 1:
javac
stderr: An exception has occurred in the compiler (1.8.0_60). Please file a bug at the Java Bug Database (http://bugreport.java.com/bugreport/) after checking the database for duplicates. Include your program and the following diagnostic in your report.  Thank you.
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found

[kageiit]

Yep. I'm in the process of untangling the dependencies and make them better isolated :)

[vanniktech]

@kageiit I'm still getting the above error (com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found) when executing the tests with version (0.16.0 and 0.16.3)

[kageiit]

Hmm. Would be great to get some repro steps at this point.

[vanniktech]

Since I'm using Java 8 in my unit tests I needed to add the rt.jar as a testCompile dependency.

Go to /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk and search for rt.jar which should be under ./Contents/Home/jre/lib/rt.jar. Copy the rt.jar into your_path/project/app/libs and then add a test dependency to this one: testCompile files('libs/rt.jar').

After this you should be able to run your unit tests.