Better watchman queries in the wrapper #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wez
reviewed
Jan 27, 2017
| ["query", "$WORKING_DIR", { | ||
| "expression": ["allof", | ||
| ["type", "f"], | ||
| ["anyof", | ||
| ["imatch", "**/BUCK", "wholename"], | ||
| ["imatch", ".buckconfig.local", "wholename"] | ||
| ["name", "BUCK"], |
There was a problem hiding this comment.
["name", ["BUCK", ".buckconfig.local"]]
turns these two lines into a faster hash set lookup
kageiit
force-pushed
the
better_watchman
branch
from
5f230d1
to
df5aaf0
Compare
kageiit
commented
Jan 27, 2017
| ["query", "$WORKING_DIR", { | ||
| "expression": ["allof", | ||
| ["type", "f"], | ||
| ["anyof", | ||
| ["imatch", "**/BUCK", "wholename"], | ||
| ["imatch", ".buckconfig.local", "wholename"] | ||
| ["name", ["BUCK", ".buckconfig.local"]] |
There was a problem hiding this comment.
@wez I have fixed this up as you suggested. Thanks!
Learnt a lot more about watchman through this exercise :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buckWrappernow creates a.watchmanconfigfile at the project root if it does not exist already