Add ability to reference resources between main and flavor res directories #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kageiit
referenced
this pull request
in facebook/buck
Jan 28, 2017
Summary:
Add an option to specify the inputs for `android_resource` as a map
instead of passing the top-level directory as a source path so that
we can avoid filesystem access during the target graph to action
graph transformation.
With this change, there are three possible ways resources and
assets can be treated:
# They are specified as a PathSourcePath. This used to be the
most common way. In this case the contents of the directory
are still traversed during the transformation, but then the
filtered files are placed in a symlink tree to ensure the
filtered out files are not used.
# They are specified as a BuildTargetSourcePath. This was not as
common and the behavior in this case does not change. There is
no FS access and the output of the rule is used in whole.
# They are specified as a map from relative path to source path.
This is a new option that behaves similarly to the first case,
except no FS access is necessary.
Future plan is to migrate all users to cases 2 or 3 and then either
disable case 1 or remove the filesystem access from it which will
mean that no filtering will take case and rule keys might diverge
if ignored files are present.
Test Plan: * `buck test`.
Reviewed By: Coneko
fbshipit-source-id: 7af04c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
This is finally possible due to an update to buck in facebook/buck@3319cd6
You need to use this sha or later in
.buckversionto get support for this feature and continue using okbuck. This also greatly simplifies the number ofandroid_resourcerules and now okbuck only creates one per target regardless of the number of itsresandassetdirectories.