Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numerous small fixes for current compatibility, otherwise android targets fail to build #966

Merged
merged 3 commits into from
Mar 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions another-app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
# removes such information by default, so configure it to keep all of it.
-keepattributes Signature

#Required from R8 in newer versions of Gradle
-keepattributes EnclosingMethod

# For using GSON @Expose annotation
-keepattributes *Annotation*

Expand Down
1 change: 0 additions & 1 deletion buildSrc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ dependencies {
implementation deps.build.rockerRuntime
implementation deps.external.guava
implementation deps.external.gson
implementation deps.lint.lintGradle

testImplementation deps.test.junit
}
Expand Down
7 changes: 4 additions & 3 deletions dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def exclude = { dep, String... excludes ->
}

def versions = [
androidPlugin : "4.1.0",
androidTools : "27.1.0",
androidPlugin : "4.2.2",
androidTools : "30.0.2",
autovalue : "1.7.4",
avro : "1.10.1",
butterKnife : "10.2.3",
Expand All @@ -34,6 +34,7 @@ def versions = [
]

def build = [
androidCommon : "com.android.tools:common:${versions.androidTools}",
androidPlugin : "com.android.tools.build:gradle:${versions.androidPlugin}",
androidPluginApi : "com.android.tools.build:gradle-api:${versions.androidPlugin}",
bcprov : "org.bouncycastle:bcprov-jdk15on:1.60",
Expand All @@ -60,7 +61,7 @@ def build = [
]

def buildConfig = [
buildTools: "30.0.3",
buildTools: "30.0.2",
compileSdk: 30,
minSdk : 21,
targetSdk : 30,
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
android.useAndroidX=true
android.enableJetifier=true
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=4096m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
1 change: 1 addition & 0 deletions kotlin-app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ dependencies {
compileOnly deps.external.annotationApi

kaptTest deps.apt.daggerCompiler
kaptTest deps.apt.daggerAndroidProcessor

testCompileOnly deps.external.annotationApi
androidTestCompileOnly deps.external.annotationApi
Expand Down
5 changes: 5 additions & 0 deletions libraries/emptylibrary/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ android {
lintOptions {
disable "HardcodedDebugMode"
}
testOptions {
unitTests {
includeAndroidResources = true
}
}
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions manifest-merger-cli/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ mainClassName = "com.uber.okbuck.manifmerger.ManifestMergerCli"

dependencies {
compileOnly deps.build.manifestMerger
compileOnly deps.build.androidCommon
}

File copyTo = project(pluginProjectPath).file("src/main/resources/com/uber/okbuck/core/util/manifest/")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ public String getPath() {
throw new UnsupportedOperationException();
}

@Override
public String getProjectName() {
throw new UnsupportedOperationException();
}

@Override
public String getVariantName() {
throw new UnsupportedOperationException();
Expand Down