Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explore logging system #694

Closed
2 tasks
edwinnglabs opened this issue Jan 22, 2022 · 1 comment · Fixed by #727
Closed
2 tasks

explore logging system #694

edwinnglabs opened this issue Jan 22, 2022 · 1 comment · Fixed by #727
Assignees
@wangzhishi
Labels
enhancement Utils and interface enhancement / more flexibility.

Comments

@edwinnglabs
Copy link
Collaborator

edwinnglabs commented Jan 22, 2022 •
edited
Loading

It seems to be a better practice in the long run to move all the print statement to log if you plan to let other packages leverage orbit. In particular, we can start to

  • organize all the print statement into appropriate logger
  • suppress stan log / and other unnecessary print in lower funnel
@edwinnglabs
Copy link
Collaborator Author

related issue #113

@edwinnglabs edwinnglabs added the enhancement Utils and interface enhancement / more flexibility. label Jan 22, 2022
@wangzhishi wangzhishi self-assigned this Mar 2, 2022
@wangzhishi wangzhishi mentioned this issue Mar 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangzhishi wangzhishi

Labels
enhancement Utils and interface enhancement / more flexibility.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev better logging uber/orbit
2 participants
@wangzhishi @edwinnglabs