Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTRX Hotfix #540

Merged
merged 1 commit into from
Aug 25, 2021
Merged

KTRX Hotfix #540

merged 1 commit into from
Aug 25, 2021

Conversation

edwinnglabs
Copy link
Collaborator

@edwinnglabs edwinnglabs commented Aug 25, 2021 •
edited
Loading

Description

A hotfix on the wrong docstring and default for arg min_residuals_sd
Fixes #543

@edwinnglabs edwinnglabs self-assigned this Aug 25, 2021
@edwinnglabs edwinnglabs added the bug Something isn't working label Aug 25, 2021
@edwinnglabs edwinnglabs changed the title KTRX Hot Fix KTRX Hotfix Aug 25, 2021
@edwinnglabs edwinnglabs added review needed need someone to review and removed bug Something isn't working labels Aug 25, 2021
@wangzhishi
Copy link
Contributor

fixes #543

wangzhishi
wangzhishi approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinnglabs edwinnglabs merged commit c9e0bbb into dev Aug 25, 2021
@edwinnglabs edwinnglabs deleted the dev-hotfix-ktrx branch August 25, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzhishi wangzhishi wangzhishi approved these changes

Assignees

@edwinnglabs edwinnglabs

Labels
review needed need someone to review
Projects
No open projects
Version 1.0.16
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KTRX min_residuals_scale
2 participants
@edwinnglabs @wangzhishi