Added last_row_consumed property to WeightedSamplingReader #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this property, make_petastorm_dataset was crashing if a WeightedSamplingReader reader was passed to it.
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
==========================================
- Coverage 86.10% 86.09% -0.02%
==========================================
Files 87 87
Lines 4967 4969 +2
Branches 791 792 +1
==========================================
+ Hits 4277 4278 +1
- Misses 562 563 +1
Partials 128 128
Continue to review full report at Codecov.
|
tkakantousis
pushed a commit
to logicalclocks/petastorm
that referenced
this pull request
Sep 16, 2020
Without this property, make_petastorm_dataset was crashing if a WeightedSamplingReader reader was passed to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this property,
make_petastorm_datasetwas crashing ifWeightedSamplingReaderreader was passed to it.