Security fix for arbitrary code execution. #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selitvin
force-pushed
the
fix_pickle_arbitarary_code_execution
branch
from
4835bcd
to
07009f7
Compare
selitvin
force-pushed
the
fix_pickle_arbitarary_code_execution
branch
3 times, most recently
from
483ce3a
to
47de2fc
Compare
selitvin
force-pushed
the
fix_pickle_arbitarary_code_execution
branch
2 times, most recently
from
886ac6e
to
13d1874
Compare
Based on uber#637: whitelists a set of packages which classes can be unpickled. Prevents unpickling a malicious class that may invoke os.execute or a similar command.
selitvin
force-pushed
the
fix_pickle_arbitarary_code_execution
branch
from
13d1874
to
9226ba5
Compare
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 86.18% 86.16% -0.02%
==========================================
Files 84 84
Lines 5051 5061 +10
Branches 788 789 +1
==========================================
+ Hits 4353 4361 +8
- Misses 559 560 +1
- Partials 139 140 +1
Continue to review full report at Codecov.
|
chongxiaoc
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #637: whitelists a set of packages which classes can be unpickled. Prevents unpickling a malicious class that may invoke
os.executeor a similar other malicious function calls.