PyTorch: improve memory-efficiency in batched non-shuffle buffer #762
Conversation
chongxiaoc
force-pushed
the
non-shuffle
branch
2 times, most recently
from
bef1fc1
to
3a0911e
Compare
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
- Coverage 86.27% 86.26% -0.01%
==========================================
Files 85 85
Lines 5084 5081 -3
Branches 785 783 -2
==========================================
- Hits 4386 4383 -3
Misses 559 559
Partials 139 139
Continue to review full report at Codecov.
|
chongxiaoc
force-pushed
the
non-shuffle
branch
2 times, most recently
from
b221591
to
6884b3a
Compare
|
@selitvin Can you take a look? |
|
Updated PR:
|
chongxiaoc
force-pushed
the
non-shuffle
branch
7 times, most recently
from
904ad1c
to
e5620b6
Compare
|
|
||
| def test_batched_noop_shuffling_buffer(): | ||
| """Check intermediate status of batched non-shuffling buffer""" | ||
| import torch |
There was a problem hiding this comment.
Can we move the import to the top?
There was a problem hiding this comment.
this is out-dated test from previous commit.
| self.store.append(batch) | ||
| self._buffer = [] | ||
| self._done_adding = False | ||
| self._batch_i = 0 |
There was a problem hiding this comment.
Perhaps a more self explanatory name instead of _batch_i? Something like first_unconsumed_row or something along the lines?
There was a problem hiding this comment.
updated with name and comments.
Avoid creating many copies in _make_batch(). Reuse same rowgroup to generate all available batches.
Avoid creating many copies in _make_batch().
Fix #763